chore: allow rdb version 12 #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romange I ignore the OPCODE all together and issue a warning. The important thing is to be able to load The person who reported this does not use cluster and wants to migrate to DF. |
Signed-off-by: kostas <[email protected]>
adiholden
reviewed
Oct 6, 2024
src/server/rdb_load.cc
Outdated
| SET_OR_RETURN(LoadLen(nullptr), slot_size); | ||
| [[maybe_unused]] uint64_t expires_slot_size; | ||
| SET_OR_RETURN(LoadLen(nullptr), expires_slot_size); | ||
| LOG(WARNING) << "Loaded and ignored RDB_OPCODE_SLOT_INFO"; |
There was a problem hiding this comment.
I believe we dont need to print this warning
adiholden
approved these changes
Oct 7, 2024
kostasrim
added a commit
that referenced
this pull request
Oct 7, 2024
We currently support rdb files up to version 11. This is a blocker for people who want to migrate to dragonfly with newer versions of the format. As of now, there is only v12 and it only includes the addition of RDB_OPCODE_SLOT_INFO. * adds support to load rdb files up to version 12 * reads and discards with a warning the contents of RDB_OPCODE_SLOT_INFO if found in the rdb file --------- Signed-off-by: kostas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support rdb files up to version
11. This is a blocker for people who want to migrate to dragonfly with newer versions of the format. As of now, there is onlyv12and it only includes the addition ofRDB_OPCODE_SLOT_INFO. For now this PR:RDB_OPCODE_SLOT_INFOif found in the rdb fileaddresses: #3859