chore: simplify CloneBatch code #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove awkward fetch_tail case and streamline the code. Fix invalid prefetch adresses. Performance improved a little. Before: `BM_Fill/elements:32000 874677 ns 874647 ns 4774` After: `BM_Fill/elements:32000 831786 ns 831761 ns 5111` Also added a benchmark for Clear() operation. Signed-off-by: Roman Gershman <[email protected]>
kostasrim
pushed a commit
that referenced
this pull request
Oct 7, 2024
Remove awkward fetch_tail case and streamline the code. Fix invalid prefetch adresses. Performance improved a little. Before: `BM_Fill/elements:32000 874677 ns 874647 ns 4774` After: `BM_Fill/elements:32000 831786 ns 831761 ns 5111` Also added a benchmark for Clear() operation. Signed-off-by: Roman Gershman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove awkward fetch_tail case and streamline the code. Fix invalid prefetch adresses. Performance improved a little.
Before:
BM_Fill/elements:32000 874677 ns 874647 ns 4774After:
BM_Fill/elements:32000 831786 ns 831761 ns 5111