chore: ClearInternal now can clear partially #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended for future use - to deallocate large objects gradually. Currently nothing is changed in the functionality besides some cleanups. Signed-off-by: Roman Gershman <[email protected]>
kostasrim
reviewed
Oct 4, 2024
src/core/dense_set.cc
Outdated
| constexpr unsigned kArrLen = 32; | ||
| ClearItem arr[kArrLen]; | ||
| unsigned len = 0; | ||
|
|
||
| for (auto it = entries_.begin(); it != entries_.end(); ++it) { | ||
| if (it->IsEmpty()) | ||
| size_t end = min<size_t>(entries_.size(), start + limit); |
There was a problem hiding this comment.
you mean limit - start here right ? Cause otherwise:
entries_.size()=10, start=3, limit=8 then end=10 and you will iterate from start=3 up to end=10 when you wanted to start from 3 and end up to limit=8.
Is there something I am missing here?
There was a problem hiding this comment.
unless you mean limit as count that is, how many elements from start you want to delete. (cause in my mind limit is more of like an index limit rather than the total elements you want to delete starting at pos start)
There was a problem hiding this comment.
I meant count, not limit
kostasrim
previously approved these changes
Oct 4, 2024
kostasrim
approved these changes
Oct 4, 2024
|
Unit failure We have an issue as well #3743 |
kostasrim
pushed a commit
that referenced
this pull request
Oct 7, 2024
* chore: ClearInternal now can clear partially Intended for future use - to deallocate large objects gradually. Currently nothing is changed in the functionality besides some cleanups. --------- Signed-off-by: Roman Gershman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended for future use - to deallocate large objects gradually. Currently nothing is changed in the functionality besides some cleanups.