chore: reduce usage of ToUpper #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to stop passing MutableSlice as arguments and removing ToUpper is the first step to it. Signed-off-by: Roman Gershman <[email protected]>
chakaz
approved these changes
Oct 6, 2024
|
Actually not obviously. Most options are less than 16 chars and we rely here on SSO that will contain the value on stack. |
yeah, that's a very good point |
kostasrim
pushed a commit
that referenced
this pull request
Oct 7, 2024
We would like to stop passing MutableSlice as arguments and removing ToUpper is the first step to it. Signed-off-by: Roman Gershman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to stop passing MutableSlice as arguments and removing ToUpper is the first step to it.