opt: Optimize AllocationTracker to be efficient when enabled
#3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today there's a cost to enabling AllocationTracker, even for rarely used memory bands. This PR slightly optimizes the "happy path" (i.e. allocations outside the tracked range), and also for the case where we track 100% of the allocations. Also, add a unit test for this class.
adiholden
approved these changes
Oct 6, 2024
kostasrim
pushed a commit
that referenced
this pull request
Oct 7, 2024
Today there's a cost to enabling AllocationTracker, even for rarely used memory bands. This PR slightly optimizes the "happy path" (i.e. allocations outside the tracked range), and also for the case where we track 100% of the allocations. Also, add a unit test for this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there's a cost to enabling AllocationTracker, even for rarely used memory bands.
This PR slightly optimizes the "happy path" (i.e. allocations outside the tracked range), and also for the case where we track 100% of the allocations.
Also, add a unit test for this class.