fix(cluster): fix unknown migration error #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakaz
approved these changes
Oct 9, 2024
|
|
no it fails on the CI as well, plz ignore |
kostasrim
approved these changes
Oct 10, 2024
|
@andydunstall plz rebase you branch once #3903 is merged |
andydunstall
force-pushed
the
fix-redundant-unknown-migration-error
branch
from
d666e40 to
7cc5b06
Compare
chakaz
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting redundant errors logs of
outgoing_slot_migration.cc:184] ERR UNKNOWN_MIGRATION(causing alerts)Looks like this is expected to be ignored.
ClusterFamily::InitMigrationreturnsSendError(OutgoingMigration::kUnknownMigration), andOutgoingMigration::SyncFbignoresCheckRespIsSimpleReply(kUnknownMigration), which doesn't matchTherefore updating
ClusterFamily::InitMigrationto respond with a simple stringSendSimpleString(OutgoingMigration::kUnknownMigration)instead so they match. AlternativelyClusterFamily::InitMigrationcould check for an error response (I'm not sure which side is right)?