chore: relax assertion in test_noreply_pipeline #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
|
@adiholden plz let me know what you think based on the description. I think relaxing the constraints should be good |
dranikpg
approved these changes
Oct 11, 2024
adiholden
approved these changes
Oct 13, 2024
I did not have other ideas 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is flaky because it depends on how fast the client will push the commands to dragonfly. Unfortunately, the problem here is that the CI can become slow (because we might run multiple regression tests on different branches) which will cause the assertion to fail. Since we don't really test here for regression (that would be the minimum amount of pipeline commands for X) but rather that we do actually pipeline I relaxed the constraints of the assertion to "at least have one pipelined command". This should make the test pass on cases where the CI becomes slow enough for the regression to show up.
Should resolve: #3896