fix: dragonfly_connection should only access the original reply_builder #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Pr4
branch
5 times, most recently
from
c98d743 to
1436a19
Compare
adiholden
reviewed
Oct 15, 2024
adiholden
previously approved these changes
Oct 15, 2024
ConnectionContext.reply_builder can be injected and replaced by the service logic. before - dragonfly_connection accessed it via cc_->reply_builder in some places, which led it to access the injected object. Moreover, EVAL commands can be offloaded to another thread and that thread could inject the object, making the access to cc_->reply_builder_ non thread-safe. Now dragonfly_connection copies aside the replier_builder_ pointer, and uses only this pointer for communicating with client. Also, remove redundant arguments. Signed-off-by: Roman Gershman <[email protected]>
adiholden
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionContext.reply_builder can be injected and replaced by the service logic.
before - dragonfly_connection accessed it via cc_->reply_builder in some places,
which led it to access the injected object. Moreover, EVAL commands can be offloaded
to another thread and that thread could inject the object, making the access to cc_->reply_builder_
non thread-safe.
Now dragonfly_connection copies aside the replier_builder_ pointer, and uses only this pointer for communicating with client.
Also, remove redundant arguments.