fix: Fix test_flushall_in_full_sync
#3929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test failed in CI many times. The issue was that we reach stable sync too quickly, and miss the full sync stage. I changed the seeder to add 100k (instead of 30k) keys for the stage to take longer.
kostasrim
previously approved these changes
Oct 15, 2024
|
@chakaz did you reproduce locally? |
yes, in release builds it fails locally for me >90% of times, with the fix it passed 1,000 times without failing |
adiholden
reviewed
Oct 15, 2024
tests/dragonfly/replication_test.py
Outdated
| @@ -1107,7 +1107,7 @@ async def test_flushall_in_full_sync(df_factory): | |||
| c_replica = replica.client() | |||
|
|
|||
| # Fill master with test data | |||
| seeder = SeederV2(key_target=30_000) | |||
| seeder = SeederV2(key_target=100_000) | |||
There was a problem hiding this comment.
please use StaticSeeder or debug populate command
adiholden
approved these changes
Oct 15, 2024
wow it did not fail for me :( |
|
maybe your machine is too slow 😆 |
Probably, is really old 😄 |
|
Fixes #3897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failed in CI many times. The issue was that we reach stable sync too quickly, and miss the full sync stage.
I changed the seeder to add 100k (instead of 30k) keys for the stage to take longer.