chore: ignore applying the same cluster config twice #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
force-pushed
the
ignore_the_same_cluster_config
branch
from
77413c1 to
b36fd11
Compare
BorysTheDev
force-pushed
the
ignore_the_same_cluster_config
branch
from
b36fd11 to
ddc276e
Compare
chakaz
approved these changes
Oct 16, 2024
Comment on lines
+58
to
+61
| std::sort(lreplicas.begin(), lreplicas.end()); | ||
| std::sort(lmigrations.begin(), lmigrations.end()); | ||
| std::sort(rreplicas.begin(), rreplicas.end()); | ||
| std::sort(rmigrations.begin(), rmigrations.end()); |
There was a problem hiding this comment.
Since the class is immutable, can we sort when we construct it? we can then DCHECK here that all is sorted, and otherwise make this comparison simpler
There was a problem hiding this comment.
yes it's possible, but I decided to write less because these vectors in most cases contain 0 or 1 elements. If you think that it's important I will rewrite this code
There was a problem hiding this comment.
I think that the code will be nicer like that (I didn't propose it for performance reasons), but it's not important :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3920
added comparison for cluster config and if the new config is equal to the previous one, we do nothing