Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to reproduce a lot of memory consumtion during migration #3939

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

BorysTheDev
Copy link
Contributor

this test is made to reproduce the problem from #3938

@BorysTheDev BorysTheDev force-pushed the add_memory_consumption_migration_test branch from ff33fd9 to 45434d1 Compare October 16, 2024 14:51
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to supply a patch for this as well or do we only want to check in the test ?

Comment on lines +2014 to +2015
df_factory.start_all(instances)
df_factory.start_all([replica])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a general note you can concat instance + replica into one statement. No action needed here just echoing the info 😄

@BorysTheDev
Copy link
Contributor Author

Don't we want to supply a patch for this as well or do we only want to check in the test ?

We want to supply a patch, but it is not a critical task and it can take a lot of time to investigate and fix the reason so we can do it after finish with the most important tasks

@BorysTheDev BorysTheDev merged commit 866c82a into main Oct 17, 2024
12 checks passed
@BorysTheDev BorysTheDev deleted the add_memory_consumption_migration_test branch October 17, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants