feat: track request sizes histograms #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces "DEBUG RECVSIZE ENABLE|DISABLE|tid" command that allows tracking of request sizes. Signed-off-by: Roman Gershman <[email protected]>
dranikpg
approved these changes
Oct 20, 2024
dranikpg
reviewed
Oct 20, 2024
| @@ -153,7 +154,8 @@ bool TrafficLogger::Write(iovec* blobs, size_t len) { | |||
| return true; | |||
| } | |||
|
|
|||
| thread_local TrafficLogger tl_traffic_logger{}; // nullopt while disabled | |||
| thread_local TrafficLogger tl_traffic_logger{}; | |||
| thread_local base::Histogram* io_req_size_hist = nullptr; | |||
There was a problem hiding this comment.
it could've been just an optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces "DEBUG RECVSIZE ENABLE|DISABLE|tid" command that allows tracking of request sizes.