chore: get rid of MutableSlice #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Pr4
branch
4 times, most recently
from
9f2b78d to
150b5a2
Compare
Signed-off-by: Roman Gershman <[email protected]>
dranikpg
previously approved these changes
Oct 20, 2024
There was a problem hiding this comment.
- Please be attentive to places like this
dragonfly/src/server/conn_context.cc
Line 165 in 3028314
Where we cast MutableSlice to ArgSlice to iterate over it, we don't need it now
- I'm not sure all copies were removed or there aren't any more places that can be simplified now
| @@ -39,14 +39,12 @@ struct Entry : public EntryBase { | |||
| // Payload represents a non-owning view into a command executed on the shard. | |||
| struct Payload { | |||
| std::string_view cmd; | |||
| std::variant<CmdArgList, // Parts of a full command. | |||
| ShardArgs, // Shard parts. | |||
| std::variant<ShardArgs, // Shard parts. | |||
dranikpg
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.