chore: tune test_rss_used_mem_gap #3958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that newer versions of the gh runner require more memory. Some cases of the test
test_rss_used_mem_gap
allocate more than6.5-7
gb of memory leaving barely0.5gb
to the gh runner (7.5 in total available) which sometimes cause the instance to run out of memory. This produces the following two cases:before
it runs out of memory.Case 1. will cause the test to fail and case 2 will cause the instance to freeze. Rather unfortunate for both cases.
This PR addresses this by tuning the test, lowering its memory requirements and also shielding dragonfly by setting
maxmemory
to5gb
such that the test fails if we reach close this number instead of making the machine (and the CI) unresponsive.Bonus point is that we trim the total running time of the test by a few minutes.