Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tune test_rss_used_mem_gap #3958

Merged
merged 1 commit into from
Oct 22, 2024
Merged

chore: tune test_rss_used_mem_gap #3958

merged 1 commit into from
Oct 22, 2024

Conversation

kostasrim
Copy link
Contributor

@kostasrim kostasrim commented Oct 21, 2024

It appears that newer versions of the gh runner require more memory. Some cases of the test test_rss_used_mem_gap allocate more than 6.5-7 gb of memory leaving barely 0.5gb to the gh runner (7.5 in total available) which sometimes cause the instance to run out of memory. This produces the following two cases:

  1. OOM-killer gets triggered and manages to iterate over all of the processes and kill df (because it consumes the most memory and the process shall have the highest rank for the algorithm) before it runs out of memory.
  2. OOM-killer gets triggered but does not manage to kill df because the system run out of memory.

Case 1. will cause the test to fail and case 2 will cause the instance to freeze. Rather unfortunate for both cases.

This PR addresses this by tuning the test, lowering its memory requirements and also shielding dragonfly by setting maxmemory to 5gb such that the test fails if we reach close this number instead of making the machine (and the CI) unresponsive.

Bonus point is that we trim the total running time of the test by a few minutes.

@kostasrim kostasrim self-assigned this Oct 21, 2024
@kostasrim
Copy link
Contributor Author

@kostasrim kostasrim requested a review from BorysTheDev October 22, 2024 07:21
@kostasrim kostasrim merged commit 1197233 into main Oct 22, 2024
16 of 17 checks passed
@kostasrim kostasrim deleted the kpr2 branch October 22, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants