test: add test to test big collections or collections with big values #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
force-pushed
the
test_big_containers
branch
from
57b08d1 to
f2783cf
Compare
dranikpg
approved these changes
Oct 22, 2024
| data_size=4000000, | ||
| collection_size=1000, | ||
| variance=100, | ||
| samples=1, |
There was a problem hiding this comment.
samples is into how many sets we divide key_target to apply variance, maybe use > 1 to have mixed-size values
There was a problem hiding this comment.
I wanted to have only one size, big or small or average maybe we can add one more test later to cover other cases
adiholden
reviewed
Oct 22, 2024
|
|
||
| @pytest.mark.asyncio | ||
| @pytest.mark.slow | ||
| async def test_big_containers(df_factory): |
There was a problem hiding this comment.
I believe that this test should be one test case for test_replication_all in which you play different config params
adiholden
reviewed
Oct 22, 2024
| seeder = StaticSeeder( | ||
| key_target=20, | ||
| data_size=4000000, | ||
| collection_size=1000, |
There was a problem hiding this comment.
- one test case for big collection with more than kMaxBlobLen = 4092 elements , to check the flow in rdb load for big containers, the size of elemets should be small in this test , testing Support huge values in RdbLoader #3760
- second test case for big values of size ~10K, we can have 2 or 3 items in the collection in this test , testing feat(server): use listpack node encoding for list #3914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3931
In this test, I simulate replication for quite big containers with different numbers of keys and different key numbers