fix: crash if we OOM during migration process #3968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
approved these changes
Oct 23, 2024
| async def test_cluster_memory_consumption_migration(df_factory: DflyInstanceFactory): | ||
| # Check data migration from one node to another | ||
| instances = [ | ||
| df_factory.create( | ||
| maxmemory="15G", |
There was a problem hiding this comment.
um CI is at best 6-7 gb of free space, if we plan to enable this test again we should take care of this. (no action needed now)
There was a problem hiding this comment.
this test isn't for CI, it's marked as skipped
| auto res = db_slice.AddNew(cntx, key, std::move(pv), args.ExpirationTime()); | ||
| res->it->first.SetSticky(args.Sticky()); | ||
| if (res) { | ||
| if (auto res = db_slice.AddNew(cntx, key, std::move(pv), args.ExpirationTime()); res) { |
There was a problem hiding this comment.
This makes sense. My question here is why do Migrations use RdbRestoreValue::Add ?
There was a problem hiding this comment.
I don't know, it's according design to use RESTORE command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: crash if add keys during OOM
I've faced this situation when investigating memory consumption increasing for cluster slot migration
maxmemory default value was 8GB and the test used 9GB. The crash happened for the target node during the migration process.
fix: check the iterator before accessing the data
Also, I've updated the test to reproduce this situation easily