fix: build break in search_family #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also perform additional clean-up of cntx->reply_builder() - Part11 Signed-off-by: Roman Gershman <[email protected]>
| @@ -1152,7 +1151,7 @@ void SDiff(CmdArgList args, Transaction* tx, SinkReplyBuilder* builder, Connecti | |||
|
|
|||
| tx->ScheduleSingleHop(std::move(cb)); | |||
| ResultSetView rsv = DiffResultVec(result_set, src_shard); | |||
| SetReplies{cntx}.Send(rsv); | |||
| SetReplies{builder, bool(cntx->conn_state.script_info)}.Send(rsv); | |||
There was a problem hiding this comment.
Maybe static_cast<bool> would be better? Same in the other places below
There was a problem hiding this comment.
I am not aware of any reason of why static_cast is better, so it falls under subjective preferences, imho.
As such, I usually prefer more concise variants.
There was a problem hiding this comment.
For informational purposes: generally c-style cast tries all kinds of casts 🤓
I quote:
- When the C-style cast expression is encountered, the compiler attempts to interpret it as the following cast expressions, in this order:
a) const_cast(expression);
b) static_cast(expression), with extensions: pointer or reference to a derived class is additionally allowed to be cast to pointer or reference to unambiguous base class (and vice versa) even if the base class is inaccessible (that is, this cast ignores the private inheritance specifier). Same applies to casting pointer to member to pointer to member of unambiguous non-virtual base;
c) a static_cast (with extensions) followed by const_cast;
d) reinterpret_cast(expression);
e) a reinterpret_cast followed by const_cast.
So the two casts are not really equivalent. But IMO it doesn't really matter and if we have any issue sanitizers will probably catch it :)
BagritsevichStepan
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also perform additional clean-up of cntx->reply_builder() - Part11