Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:update fakeredis, remove irrelevant tests #4014

Merged
merged 4 commits into from
Nov 17, 2024
Merged

chore:update fakeredis, remove irrelevant tests #4014

merged 4 commits into from
Nov 17, 2024

Conversation

cunla
Copy link
Contributor

@cunla cunla commented Oct 29, 2024 •
edited
Loading

  • Update fakeredis to v2.26.1
  • Remove tests relevant for redis versions before v7.
  • Simplified test_stack to be ignored by using the mark on the file level instead of every test.
  • Fix test_set_commands to support output from redis-py v5.1 (list instead of set).

@cunla cunla marked this pull request as ready for review October 29, 2024 15:29
romange
romange approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cunla !

@romange romange merged commit d241839 into dragonflydb:main Nov 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romange romange romange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cunla @romange