Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decouple reply_builder from ConnectionContext #4069

Merged
merged 1 commit into from
Nov 10, 2024
Merged

chore: decouple reply_builder from ConnectionContext #4069

merged 1 commit into from
Nov 10, 2024

Conversation

romange
Copy link
Collaborator

@romange romange commented Nov 5, 2024

No description provided.

@romange romange force-pushed the Pr1 branch 2 times, most recently from 81b578c to d3da8bb Compare November 5, 2024 17:14
@dranikpg
Copy link
Contributor

dranikpg commented Nov 7, 2024

Please wait for #3953

@romange
Copy link
Collaborator Author

romange commented Nov 10, 2024

@dranikpg I did not understand why you added Protocol::NONE , it's not needed imho.

@romange romange requested review from chakaz and removed request for dranikpg November 10, 2024 15:58
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@romange romange merged commit 50473b5 into main Nov 10, 2024
12 checks passed
@romange romange deleted the Pr1 branch November 10, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants