-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(search_family): Process wrong field types in indexes for the FT.SEARCH and FT.AGGREGATE commands #4070
fix(search_family): Process wrong field types in indexes for the FT.SEARCH and FT.AGGREGATE commands #4070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will wait for @dranikpg to review , meanwhile some minor comments so I could understand the PR better
1b4f480
to
1b4625a
Compare
@romange I've added more tests. After adding support for nullable values, a more tests will be added. Please take a look at the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My two cents:
- Please write next time what you changed in the PR description, so I can dive into the changes quicker
- Maybe look into unifying Matches() and Add(), this would simplify code
- Please check vectors or add a TODO
If we hurry for a release I can approve 🙂
6a98c85
to
c6bbca9
Compare
I found several new bugs and fixed them in the latest commit:
I’ve also added more tests |
3ca4592
to
d8dd8cb
Compare
Found and fixed another bug: We should support queries like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job fixing bugs around vector parsing, it wasn't safe before.
Still, once we merge this for 1.25, I'd suggest to unite IsValidFieldType and Add, because we have safe/unsafe parsing functions, optionals that are dereferenced "by implicit contract" and double effort indexing documents (we parse it two times)
Signed-off-by: Stepan Bagritsevich <[email protected]>
…EARCH and FT.AGGREGATE commands fixes dragonflydb#3986 Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
…:InlinedVector>> Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
9ba0a2f
to
8c41a20
Compare
…EARCH and FT.AGGREGATE commands (#4070) * fix(search_family): Process wrong field types in indexes for the FT.SEARCH and FT.AGGREGATE commands fixes #3986 --------- Signed-off-by: Stepan Bagritsevich <[email protected]>
fixes #3986