Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cluster migrations restarts if timeout happens #4081

Merged
merged 14 commits into from
Nov 25, 2024
Merged

feat: cluster migrations restarts if timeout happens #4081

merged 14 commits into from
Nov 25, 2024

Conversation

BorysTheDev
Copy link
Contributor

@BorysTheDev BorysTheDev commented Nov 7, 2024 •
edited
Loading

fixes: #4080
added test for #3247 but it is flaky so it is skipped for now

@BorysTheDev BorysTheDev force-pushed the migration_restart_for_timeout branch 2 times, most recently from 1b355a3 to 3301cd3 Compare November 16, 2024 16:30
@BorysTheDev BorysTheDev changed the title feat: cluster migrations restarts if timeout happens (not ready for review) feat: cluster migrations restarts if timeout happens Nov 16, 2024
@BorysTheDev BorysTheDev force-pushed the migration_restart_for_timeout branch from 3301cd3 to 238aaa7 Compare November 16, 2024 16:36
@BorysTheDev BorysTheDev force-pushed the migration_restart_for_timeout branch from 9773e0e to bf3302a Compare November 17, 2024 15:16
@BorysTheDev BorysTheDev mentioned this pull request Nov 17, 2024
Merged
@BorysTheDev BorysTheDev force-pushed the migration_restart_for_timeout branch 4 times, most recently from 97b0bf1 to f70beb2 Compare November 19, 2024 09:22
@BorysTheDev BorysTheDev force-pushed the migration_restart_for_timeout branch from 901f231 to 6d67695 Compare November 21, 2024 09:46
@BorysTheDev BorysTheDev mentioned this pull request Nov 21, 2024
Closed
adiholden
adiholden reviewed Nov 21, 2024
View reviewed changes
tests/dragonfly/cluster_test.py Outdated Show resolved Hide resolved
tests/dragonfly/cluster_test.py Outdated Show resolved Hide resolved
tests/dragonfly/cluster_test.py Outdated Show resolved Hide resolved
tests/dragonfly/cluster_test.py Outdated Show resolved Hide resolved
src/server/journal/streamer.cc Show resolved Hide resolved
src/server/journal/streamer.cc Outdated Show resolved Hide resolved
@BorysTheDev BorysTheDev force-pushed the migration_restart_for_timeout branch from 6d67695 to 2966f03 Compare November 21, 2024 12:00
@BorysTheDev BorysTheDev force-pushed the migration_restart_for_timeout branch from 2966f03 to e1b64fb Compare November 21, 2024 15:17
@BorysTheDev BorysTheDev force-pushed the migration_restart_for_timeout branch from e1b64fb to 34dfd9f Compare November 25, 2024 10:56
@BorysTheDev BorysTheDev merged commit 43c83d2 into main Nov 25, 2024
9 checks passed
@BorysTheDev BorysTheDev deleted the migration_restart_for_timeout branch November 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiholden adiholden adiholden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrations fail with no reported error
2 participants
@BorysTheDev @adiholden