chore: Implement list Pop/Erase functionality with QList #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted OpRem/OpBPop/OpPop Signed-off-by: Roman Gershman <[email protected]>
BorysTheDev
reviewed
Nov 10, 2024
| @@ -355,6 +355,40 @@ void QList::Push(string_view value, Where where) { | |||
| } | |||
| } | |||
|
|
|||
| string QList::Pop(Where where) { | |||
There was a problem hiding this comment.
Just to think: we can create our own string_view type (that can contain string_view or short string for 19 symbols) and return it without allocations
There was a problem hiding this comment.
You don't need to optimize by space, so it can be just a variant<string, string_view>
There was a problem hiding this comment.
we can not return string_view if we pop. in any case it's not urgent and can not be done easily during the transition.
there is no regression here.
BorysTheDev
reviewed
Nov 10, 2024
Comment on lines
+628
to
+631
| if (is_int) { | ||
| return entry.is_int() && entry.ival() == ival; | ||
| } | ||
| return entry == elem; |
There was a problem hiding this comment.
return is_int ? entry.is_int() && entry.ival() == ival : entry == elem;
There was a problem hiding this comment.
will fix in the subsequent pr
BorysTheDev
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted OpRem/OpBPop/OpPop