chore: Implement LMOVE over QList #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests in list_family_test besides LTrim pass. Signed-off-by: Roman Gershman <[email protected]>
BorysTheDev
reviewed
Nov 10, 2024
src/server/list_family.cc
Outdated
| int pos = (dest_dir == ListDir::LEFT) ? QUICKLIST_HEAD : QUICKLIST_TAIL; | ||
| quicklistPush(src_ql, val.data(), val.size(), pos); | ||
| } else { | ||
| val = srcql_v2->Pop(src_dir == ListDir::LEFT ? QList::HEAD : QList::TAIL); |
There was a problem hiding this comment.
Could you create a function to make ToPosition(ListDir dir) {return dir == ListDir::LEFT ? QList::HEAD : QList::TAIL}
BorysTheDev
reviewed
Nov 10, 2024
BorysTheDev
reviewed
Nov 10, 2024
BorysTheDev
reviewed
Nov 10, 2024
BorysTheDev
approved these changes
Nov 10, 2024
BorysTheDev
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests in list_family_test besides LTrim pass.