Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip Send() in SinkReplyBuilder::Flush() when vec is empty #4114

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: skip Send() in SinkReplyBuilder::Flush() when vec is empty #4114

merged 1 commit into from
Nov 11, 2024

Conversation

kostasrim
Copy link
Contributor

@kostasrim kostasrim commented Nov 11, 2024 •
edited
Loading

#3953 removed SendMGetResponse and we ended up calling Send() when sink_ is nullptr which had no effect because the vec was empty.

@kostasrim kostasrim self-assigned this Nov 11, 2024
@kostasrim kostasrim requested a review from romange November 11, 2024 12:40
@kostasrim
Copy link
Contributor Author

Sanitizers run https://github.com/dragonflydb/dragonfly/actions/runs/11778734685

@kostasrim kostasrim changed the title fix: nullptr access within reply builder fix: dereference nullptr within reply builder Nov 11, 2024
romange
romange reviewed Nov 11, 2024
View reviewed changes
src/facade/reply_builder.h Outdated Show resolved Hide resolved
@kostasrim kostasrim requested a review from romange November 11, 2024 13:11
@kostasrim kostasrim changed the title fix: dereference nullptr within reply builder fix: skip Send() in SinkReplyBuilder::Flush() when vec is empty Nov 11, 2024
@kostasrim kostasrim enabled auto-merge (squash) November 11, 2024 17:23
@kostasrim kostasrim merged commit 0facd6f into main Nov 11, 2024
12 checks passed
@kostasrim kostasrim deleted the kpr4 branch November 11, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romange romange romange approved these changes

Assignees

@kostasrim kostasrim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostasrim @romange