fix: enforce load limits when loading snapshot #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
reviewed
Nov 17, 2024
|
What about dfly load append command? |
|
This command is not interesting as is only used for migrations which are ad hoc at this point. |
Prevent loading snapshots with used memory higher than max memory limit. 1. Store the used memory metadata only inside the summary file 2. Load the summary file before loading anything else, and if the used-memory is higher, abort the load. Signed-off-by: Roman Gershman <[email protected]>
romange
force-pushed
the
EnfoceLoadLimits
branch
from
0e25ec1 to
ec6d075
Compare
adiholden
reviewed
Nov 19, 2024
| @@ -646,4 +646,13 @@ TEST_F(RdbTest, LoadHugeStream) { | |||
| ASSERT_EQ(2000, CheckedInt({"xlen", "test:0"})); | |||
| } | |||
|
|
|||
| TEST_F(RdbTest, SnapshotTooBig) { | |||
| // Run({"debug", "populate", "10000", "foo", "1000"}); | |||
There was a problem hiding this comment.
nit: you can remove the lines in comment
adiholden
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent loading snapshots with used memory higher than max memory limit.