feat: add INFO memory section for squashing replies memory consuming #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
force-pushed
the
add_info_memory_for_squashing_replies
branch
from
f281be5 to
803302e
Compare
romange
reviewed
Nov 18, 2024
romange
reviewed
Nov 18, 2024
romange
reviewed
Nov 18, 2024
romange
reviewed
Nov 18, 2024
romange
approved these changes
Nov 18, 2024
adiholden
reviewed
Nov 19, 2024
| @@ -238,6 +274,7 @@ bool MultiCommandSquasher::ExecuteSquashed(facade::RedisReplyBuilder* rb) { | |||
| aborted |= error_abort_ && CapturingReplyBuilder::TryExtractError(replies.back()); | |||
|
|
|||
| CapturingReplyBuilder::Apply(std::move(replies.back()), rb); | |||
| current_reply_size_.fetch_sub(Size(replies.back()), std::memory_order_relaxed); | |||
There was a problem hiding this comment.
there is std::move line above on replies.back()
There was a problem hiding this comment.
That move does nothing there, unfortunately. But I've added a fix https://github.com/dragonflydb/dragonfly/pull/4149/files
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of the #4002
added INFO memory field "commnads_squashing_replies_bytes" to show the current consumption for replies of squashing commands