fix: remove DenseSet::IteratorBase::TraverseApply #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
|
@romange I can also disable the whole defrag logic for string map until we are sure what the root cause is. It's your call |
|
what version does this revert correspond to? |
The PR that introduced this change is part of 1.25. Therefore, by removing it we get the behavior of 1.24 |
romange
approved these changes
Nov 23, 2024
romange
pushed a commit
that referenced
this pull request
Nov 24, 2024
Signed-off-by: kostas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts #4019 because:
DefragStrMap2callsReallocIfNeeded()on eachStringMap::iteratorand the traversal also includes all of the elements of a alllinks. This TraverseApply just adds extra iterations, if theiteratorpassed islink.I am still not sure if
TraverseApplyactually causes the crash described in (2)