chore: more parser improvements #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The long-term goal is to make the parser to consume the whole input when it returns INPUT_PENDING. It requires several baby step PRs. This PR: 1. Adds more invariant checks 2. Avoids calling RedisParser::Parse with an empty buffer. 3. In bulk string parsing - remove redundant "optimization" of rejecting partial strings of less than 32 bytes, in other words consume small parts as well. The unit test adjusted accordingly. Signed-off-by: Roman Gershman <[email protected]>
romange
commented
Nov 25, 2024
| ASSERT_EQ(RedisParser::INPUT_PENDING, Parse(kFirst)); | ||
| ASSERT_EQ(strlen(kFirst) - 4, consumed_); | ||
| ASSERT_EQ(strlen(kFirst), consumed_); |
There was a problem hiding this comment.
This is the only functional change of this PR: we now consume the small part of a bulk string. In this case key:.
BorysTheDev
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long-term goal is to make the parser to consume the whole input when
it returns INPUT_PENDING. It requires several baby step PRs.
This PR:
in other words consume small parts as well. The unit test adjusted accordingly.