chore: produce core files in regtests #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should work only for self-hosted runners. The core files will be kept in /var/crash/ We also copy automatically dragonfly binary into /var/crash to be able to debug later. Signed-off-by: Roman Gershman <[email protected]>
kostasrim
approved these changes
Nov 25, 2024
| @@ -15,7 +15,7 @@ pytest-repeat==0.9.3 | |||
| pymemcache==4.0.0 | |||
| prometheus_client==0.17.0 | |||
| aiohttp==3.10.2 | |||
| numpy==1.24.3 | |||
| numpy | |||
There was a problem hiding this comment.
because numpy is better to install via apt and its version depends on each linux distribution.
our regest code does not rely on a specific numpy version
Comment on lines
+64
to
+65
| if: failure() | ||
| run: | |
There was a problem hiding this comment.
Not sure if you "tested" this. I can inject a failure to make sure that it works if you can wait until tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work only for self-hosted runners.
The core files will be kept in /var/crash/
We also copy automatically dragonfly binary into /var/crash to be able to debug later.