feat: add ability reading stream_listpacks_2/3 rdb types #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
force-pushed
the
support_stream_listpacks_2_3_rdb_types
branch
from
474ed3e to
91f6c0c
Compare
romange
reviewed
Nov 26, 2024
src/server/rdb_load.cc
Outdated
| load_trace->stream_trace->entries_added = load_trace->stream_trace->stream_len; | ||
|
|
||
| /* Since the rax is already loaded, we can find the first entry's * ID. */ | ||
| // TODO add implementation |
There was a problem hiding this comment.
it's not clear from TODO what needs to be implemented. What are the the values we read but discarded. Please expand on it.
romange
reviewed
Nov 26, 2024
romange
reviewed
Nov 26, 2024
romange
reviewed
Nov 26, 2024
BorysTheDev
force-pushed
the
support_stream_listpacks_2_3_rdb_types
branch
from
e19816f to
18ebdff
Compare
romange
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4159