Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Track QList memory #4226

Merged
merged 2 commits into from
Nov 29, 2024
Merged

chore: Track QList memory #4226

merged 2 commits into from
Nov 29, 2024

Conversation

romange
Copy link
Collaborator

@romange romange commented Nov 29, 2024

After running debug POPULATE 100 list 100 rand type list elements 10000 with --list_experimental_v2=false:

type_used_memory_list:16512800
used_memory:105573120

When running with --list_experimental_v2=true:

used_memory:105573120
type_used_memory_list:103601700

TODO: does not yet handle compressed entries correctly but we do not enable compression by default.

Fixes #3800

@romange romange requested a review from BorysTheDev November 29, 2024 08:53
After running `debug POPULATE 100 list 100 rand type list elements 10000`
with `--list_experimental_v2=false`:

```
type_used_memory_list:16512800
used_memory:105573120
```

When running with `--list_experimental_v2=true`:

```
used_memory:105573120
type_used_memory_list:103601700
```

TODO: does not yet handle compressed entries correctly but we do not enable compression by default.

Fixes #3800

Signed-off-by: Roman Gershman <[email protected]>
BorysTheDev
BorysTheDev previously approved these changes Nov 29, 2024
@romange romange enabled auto-merge (squash) November 29, 2024 09:15
@romange romange merged commit 3ad5b38 into main Nov 29, 2024
9 checks passed
@romange romange deleted the QL3 branch November 29, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List types memory tracking is inaccurate
2 participants