chore: update command interface for bitops, bloom, zset families #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
reviewed
Dec 1, 2024
Comment on lines
+42
to
+48
| void BitPos(CmdArgList args, const CommandContext& cmd_cntx); | ||
| void BitCount(CmdArgList args, const CommandContext& cmd_cntx); | ||
| void BitField(CmdArgList args, const CommandContext& cmd_cntx); | ||
| void BitFieldRo(CmdArgList args, const CommandContext& cmd_cntx); | ||
| void BitOp(CmdArgList args, const CommandContext& cmd_cntx); | ||
| void GetBit(CmdArgList args, const CommandContext& cmd_cntx); | ||
| void SetBit(CmdArgList args, const CommandContext& cmd_cntx); |
There was a problem hiding this comment.
I don't think that const for CommandContext is ok, because we update it
There was a problem hiding this comment.
we never change any of the fields of the struct, otherwise it would not compile. but I understand what you are saying.
BorysTheDev
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.