chore(rax_tree): Introduce raxFreeWithCallback call in RaxTreeMap destructor #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BagritsevichStepan
force-pushed
the
df.search/rax-tree-add-raxFreeWithCallback
branch
from
4c9cb6e to
aebcbdc
Compare
kostasrim
reviewed
Dec 4, 2024
| } | ||
|
|
||
| /* Free a whole radix tree with a callback */ | ||
| void raxFreeWithCallback(rax *rax, void (*free_callback)(void*)) { |
BagritsevichStepan
force-pushed
the
df.search/rax-tree-add-raxFreeWithCallback
branch
from
aebcbdc to
c292bfe
Compare
…tructor Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
df.search/rax-tree-add-raxFreeWithCallback
branch
from
c292bfe to
2f13e11
Compare
BagritsevichStepan
requested review from
BorysTheDev and
chakaz
and removed request for
kostasrim
chakaz
reviewed
Dec 16, 2024
| rax_free(n); | ||
| rax->numnodes--; | ||
| } | ||
|
|
||
| /* Free the entire radix tree, invoking a free_callback function for each key's data. | ||
| * An additional argument is passed to the free_callback function.*/ | ||
| void raxFreeWithCallbackAndArgument(rax *rax, void (*free_callback)(void*, void*), void* argument) { |
There was a problem hiding this comment.
Should we call this:
Suggested change
| void raxFreeWithCallbackAndArgument(rax *rax, void (*free_callback)(void*, void*), void* argument) { | |
| void raxRecursiveFreeWithCallbackAndArgument(rax *rax, void (*free_callback)(void*, void*), void* argument) { |
?
There was a problem hiding this comment.
I don't think so, because Redis provides raxFreeWithCallback as a public API. And raxRecursiveFree is an internal method and not part of the public API. So for consistency, I think raxFreeWithCallbackAndArgument would be a better choice.
chakaz
approved these changes
Dec 17, 2024
| rax_free(n); | ||
| rax->numnodes--; | ||
| } | ||
|
|
||
| /* Free the entire radix tree, invoking a free_callback function for each key's data. | ||
| * An additional argument is passed to the free_callback function.*/ | ||
| void raxFreeWithCallbackAndArgument(rax *rax, void (*free_callback)(void*, void*), void* argument) { |
BagritsevichStepan
deleted the
df.search/rax-tree-add-raxFreeWithCallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to this comment