fix: crash during getting info about replication #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
previously approved these changes
Dec 17, 2024
BorysTheDev
force-pushed
the
crash_INFO_cmd_druing_replication
branch
from
2fc807c to
61a5a3b
Compare
romange
reviewed
Dec 17, 2024
| @@ -1333,6 +1333,8 @@ size_t RdbSaver::Impl::GetTotalBuffersSize() const { | |||
|
|
|||
| auto cb = [this, &channel_bytes, &serializer_bytes](ShardId sid) { | |||
| auto& snapshot = shard_snapshots_[sid]; | |||
| if (!snapshot) | |||
There was a problem hiding this comment.
@BorysTheDev please add a comment explaining how come RdbSave::Impl with shard_snapshots_ exist but they are not initialized yed.
romange
reviewed
Dec 17, 2024
| @@ -1355,6 +1357,8 @@ RdbSaver::SnapshotStats RdbSaver::Impl::GetCurrentSnapshotProgress() const { | |||
|
|
|||
| auto cb = [this, &results](ShardId sid) { | |||
| auto& snapshot = shard_snapshots_[sid]; | |||
| if (!snapshot) | |||
BorysTheDev
force-pushed
the
crash_INFO_cmd_druing_replication
branch
from
61a5a3b to
be70b39
Compare
romange
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: we try to get the memory info during replication start, but the snapshot object doesn't exist yet