fix: do not check-fail in OpRestore #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
changed the title
In some rare cases we reach inconsistent state inside OpRestore where a key already exists, though it should not. In that case log the error instead of crashing the server. In addition, we update the existing entry to the latest restored value. Signed-off-by: Roman Gershman <[email protected]>
BorysTheDev
approved these changes
Dec 18, 2024
romange
added a commit
that referenced
this pull request
Dec 18, 2024
fix: do not check-fail OpRestore In some rare cases we reach inconsistent state inside OpRestore where a key already exists, though it should not. In that case log the error instead of crashing the server. In addition, we update the existing entry to the latest restored value. Signed-off-by: Roman Gershman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases we reach inconsistent state inside OpRestore where a key already exists, though it should not. In that case log the error instead of crashing the server. In addition, we update the existing entry to the latest restored value.