Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove transaction lib on cluster code dependency #4417

Merged
merged 1 commit into from
Jan 8, 2025
Merged

refactor: remove transaction lib on cluster code dependency #4417

merged 1 commit into from
Jan 8, 2025

Conversation

BorysTheDev
Copy link
Contributor

fixes: #3839

  • no logic was changed
  • remove transaction lib dependency on cluster
  • remove extra headers

romange
romange reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BorysTheDev BorysTheDev force-pushed the remove_transaction_on_cluster_dependency branch from 22d9212 to d89dfdd Compare January 8, 2025 08:53
@BorysTheDev BorysTheDev requested a review from romange January 8, 2025 08:55
@BorysTheDev BorysTheDev enabled auto-merge (squash) January 8, 2025 09:18
@BorysTheDev BorysTheDev merged commit 933c9f0 into main Jan 8, 2025
9 checks passed
@BorysTheDev BorysTheDev deleted the remove_transaction_on_cluster_dependency branch January 8, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romange romange romange approved these changes

@chakaz chakaz Awaiting requested review from chakaz

@adiholden adiholden Awaiting requested review from adiholden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transaction library shouldn't depend on the cluster files
2 participants
@BorysTheDev @romange