chore: split geo and zset families #4421
Merged
+1,070
−956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Jan 7, 2025
src/server/geo_family.h
Outdated
| class GeoFamily { | ||
| public: | ||
| static void Register(CommandRegistry* registry); | ||
| using SinkReplyBuilder = facade::SinkReplyBuilder; |
There was a problem hiding this comment.
I do not think you need it here, nor its declaration at line 12.
romange
reviewed
Jan 7, 2025
| using SinkReplyBuilder = facade::SinkReplyBuilder; | ||
| template <typename T> using OpResult = facade::OpResult<T>; | ||
|
|
||
| static void ZAddGeneric(std::string_view key, const ZParams& zparams, ScoredMemberSpan memb_sp, |
There was a problem hiding this comment.
what's the reason for exposing ZAddGeneric here?
There was a problem hiding this comment.
ah, i see.
please add a comment that it's being used in geo_family.cc code.
Signed-off-by: kostas <[email protected]>
romange
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was longing for this change for some time now and I grabbed the opportunity since I already worked on #4420
I am not sure how I could reduce the size of the PR.
There are no functional changes only a refactor.
TODO for separate PR
ZSetFamily::to a separate file