refactor(server): Refactor replica #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
commented
Nov 8, 2022
Comment on lines
+539
to
+541
| std::unique_ptr<base::IoBuf> io_buf{new base::IoBuf(128)}; | ||
| unsigned consumed = 0; | ||
| RETURN_ON_ERR(ReadRespReply(io_buf.get(), &consumed)); // uses parser_ |
There was a problem hiding this comment.
I don't really like the whole we-are-throwing-bytes-around-manually vibe. A parsed response with RAII semantics (drop or re-assign) would be really handy... But its likely over-engineering
There was a problem hiding this comment.
the moment you get me a PoC with "set" only replication that includes full-sync and the journal - you do whatever refactorings you want plus 👸🏼 to marry plus half 👑 .
There was a problem hiding this comment.
The PoC is in the replication branch 😎 I'll do the refactoring sometime later. Its just the more hard code we have, the more efforts we need in the future to fix it all
|
Lets keep it like now if everything is fine |
romange
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating replication branch on main, part 5
The replica became an manageable 1k LOC mess 🤯 Time to fix technical debt 🔧 🔨
Mixed implementation: