fix(server): all scan commands needs to return cursor as bulk string #503 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
reviewed
Nov 21, 2022
Comment on lines
72
to
76
| def generate_key_val(): | ||
| now = datetime.datetime.now() | ||
| for i in range(10): | ||
| string_val = "".join(random.choice(ascii_lowercase) for i in range(random.randint(1, 8))) | ||
| yield f"key{i}-{time.time()}", f"value={i}{string_val}{now}" |
There was a problem hiding this comment.
I have this kind of stuff without timestamps in utility.py as gen_test_data (note, there should be no randomicity if you change it)
I have also bulk filling for setting large amounts of values in mset commands
I know its just tests, but maybe we can make such utils re-usable
There was a problem hiding this comment.
OK - I took this test from some offline code I have - I will change it
Signed-off-by: Boaz Sade <[email protected]>
boazsade
force-pushed
the
redisson-client-sscan
branch
from
287ccdd to
2b5f33a
Compare
romange
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boaz Sade [email protected]
fixes issue #503
The scan commands - scan, hscan, zscan, sscan all should return bulk string and not a "regular string" for the cursor value.
This issue was found as a result of running a java client (redisson source code, that expecting to have the correct data type for this case.