Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(rdb loader): When reading from zstd uncompressed buf skip ensure … #525

Merged
merged 2 commits into from
Dec 4, 2022

Conversation

adiholden
Copy link
Collaborator

No description provided.

@adiholden adiholden requested a review from romange December 1, 2022 14:45
@adiholden
Copy link
Collaborator Author

This PR will fix the fail in regression test

romange
romange previously approved these changes Dec 1, 2022
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of a way to unit test it? Maybe unit test rdbloader directly?

@adiholden
Copy link
Collaborator Author

@romange I added unit test and updated the comment, please see the last commit

@adiholden adiholden requested a review from romange December 4, 2022 08:57
@romange romange merged commit c7974a4 into main Dec 4, 2022
@romange romange deleted the loader_with_compression_bug branch December 4, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants