Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): defrag unit test fix #602

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

boazsade
Copy link
Contributor

Signed-off-by: Boaz Sade [email protected]
fix issue #571

There was an issue with the defrag unit test that when run by its own it would not start the task that collect the use memory stats from all shards. This would result in the task for defrag not running because the use memory == 0.
On top of it, there was an issue that since this started with empty memory the defrag task was not ran by other tests, and so the counter for running the defrag test was not activated.
Note that since we're going to rewrite the logic for defrag, this is going to change soon again, but for now, it required that this test will work correctly.
To ensure that the test is ran with less memory the flag that control the memory threshold is set as well.
The test also set enough memory so that we would not have issue with setting all the keys.

@romange romange merged commit 044d4a4 into dragonflydb:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants