feat(tools):Cache logs player #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashotland <[email protected]>
dranikpg
approved these changes
Dec 28, 2022
Comment on lines
+76
to
+80
| cmd = await asyncio.wait_for(self.queue.get(), timeout=1.0) | ||
| batch.append(cmd) | ||
| if len(batch) >= self.BATCH_SIZE: | ||
| await self.execute(batch) | ||
| batch.clear() |
There was a problem hiding this comment.
If you group the values on the producer side instead and send them over the channel in batches you would reduce the pressure on the asyncio scheduler
But I suspect its not a bottleneck here, besides managing the timeout to send half filled batches from the producer would be a little inconvenient
There was a problem hiding this comment.
@dranikpg thanks, good feedback.
romange
reviewed
Dec 28, 2022
| elif operation == 'cas': | ||
| cmd.args = ["SET", key, synthetic_value] | ||
| elif operation == 'append': | ||
| cmd.args = ["SET", key, synthetic_value] |
There was a problem hiding this comment.
@ashotland redis has append I think
There was a problem hiding this comment.
Correct, will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ashotland [email protected]