feat(server): Buffered journal serializers #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <[email protected]>
adiholden
reviewed
Dec 29, 2022
adiholden
reviewed
Dec 29, 2022
adiholden
reviewed
Dec 29, 2022
src/server/journal_test.cc
Outdated
| for (const auto& entry : test_entries) { | ||
| writer.Write(entry); | ||
| } | ||
|
|
||
| // Read them back. | ||
| io::BytesSource bs{io::Buffer(ss.str())}; | ||
| JournalReader reader{0}; | ||
| io::BytesSource bs{writer.Accumulated()}; |
There was a problem hiding this comment.
The Accumulated function is only used in test.. Why do you use it and not just flush to io::StringSink ?
There was a problem hiding this comment.
Indeed, I forgot to make rdb saver use it as well. Its better than doing a double copy
adiholden
reviewed
Dec 29, 2022
adiholden
reviewed
Dec 29, 2022
adiholden
reviewed
Dec 29, 2022
| JournalWriter writer{flow->conn->socket()}; | ||
| auto journal_cb = [flow, writer = std::move(writer)](const journal::Entry& je) mutable { | ||
| writer.Write(je); | ||
| writer = new JournalWriter{}; |
There was a problem hiding this comment.
maybe the writer can be in flow struct, as rdb save is in flow
There was a problem hiding this comment.
There is no need to, it will be replaced anyway in the next pr
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
commented
Dec 29, 2022
Comment on lines
+27
to
29
| // Return reference to internal buffer. | ||
| base::IoBuf& Accumulated(); | ||
|
|
There was a problem hiding this comment.
I want to make base::IoBuf movable in helio and then let the new journal streamer just swap it instead of doing a copy
| await asyncio.sleep(0.5) | ||
| await asyncio.sleep(1.0) |
There was a problem hiding this comment.
I suspect they failed last time because of the small delay
romange
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.