feat(server): Update helio, optimize and clean up rdb/snapshot #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
commented
Dec 30, 2022
Comment on lines
+98
to
+99
| // Push byte slice to channel. | ||
| void PushBytesToChannel(DbIndex db_index, io::Bytes bytes); |
There was a problem hiding this comment.
My idea:
If I'll be implementing an async writer with the IoBuf swapping technique, then I can use it for single shard snapshots as well instead of a channel with small portions
There was a problem hiding this comment.
Why is it important? Take into account that iobuf is not optimized for being a queue. It may realloc heavily for variable size workloads. I think it's too soon to start optimizing the code towards a winning approach.
Comment on lines
-147
to
-148
| // TODO : drop default_buffer from this class, we dont realy need it. | ||
| std::unique_ptr<io::StringFile> default_buffer_; // filled by default_serializer_ |
There was a problem hiding this comment.
Either way removing this is intended
Signed-off-by: Vladislav Oleshko <[email protected]>
romange
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.