feat(server): Rewrite journal commands (basic) #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
commented
Jan 7, 2023
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
rewrite-expire-journal
branch
from
e4141c7 to
c139bc8
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
rewrite-expire-journal
branch
from
1b030b6 to
30c170a
Compare
Signed-off-by: Vladislav <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
adiholden
reviewed
Jan 15, 2023
src/server/common.cc
Outdated
| @@ -190,6 +192,12 @@ bool ParseDouble(string_view src, double* value) { | |||
| return true; | |||
| } | |||
|
|
|||
| void OpArgs::RecordJournal(string_view key, ArgSlice args) const { | |||
adiholden
reviewed
Jan 15, 2023
src/server/common.cc
Outdated
| void OpArgs::RecordJournal(string_view key, ArgSlice args) const { | ||
| auto journal = shard->journal(); | ||
| CHECK(journal); | ||
| journal->RecordEntry(txid, journal::Op::COMMAND, db_cntx.db_index, 1, make_pair(key, args)); |
There was a problem hiding this comment.
this records can be part of multi transaction and in this case we should use MULTI_COMMAND
Signed-off-by: Vladislav <[email protected]>
adiholden
reviewed
Jan 15, 2023
src/server/db_slice.cc
Outdated
| if (auto journal = owner_->journal(); journal) { | ||
| string scratch; | ||
| auto payload = make_pair("DEL"sv, ArgSlice{it->first.GetSlice(&scratch)}); | ||
| journal->RecordEntry(0, journal::Op::COMMAND, cntx.db_index, 1, payload); |
There was a problem hiding this comment.
Do you know to tell if this flow will not happen while executing multi command?
If it does, it will break the current impl in replica as if it gets multi command from journal it reads more multi commands till it gets exec. Replica assumes that there is no command op entry that was inserted before the exec op was reached
adiholden
reviewed
Jan 15, 2023
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
rewrite-expire-journal
branch
from
8070b9c to
4e0ba46
Compare
dranikpg
commented
Jan 16, 2023
dranikpg
changed the title
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
rewrite-expire-journal
branch
from
3da1b84 to
4eeb6c8
Compare
adiholden
reviewed
Jan 16, 2023
Signed-off-by: Vladislav Oleshko <[email protected]>
adiholden
approved these changes
Jan 16, 2023
adiholden
reviewed
Jan 16, 2023
| } else { | ||
| auto time = absl::StrCat(res.value()); | ||
| // Note: Don't forget to change this when adding arguments to expire commands. | ||
| op_args.RecordJournal("PEXPIREAT"sv, ArgSlice{time}); |
There was a problem hiding this comment.
where is the key in PEXPIREAT journal write?
There was a problem hiding this comment.
Damn 😓 I'll fix it in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.