fix(lua): fix a bug that truncates the last lua argument. #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
previously approved these changes
Jan 7, 2023
dranikpg
reviewed
Jan 7, 2023
This happens when the last argument is a number because SNPrintF makes sure to write \0 even though we did not account of that when passing capacity. Since we allocate more than we use, the only thing we need to do is to pass larger capacity. Signed-off-by: Roman Gershman <[email protected]>
romange
force-pushed
the
FixLastNumTrunc
branch
from
250dd30 to
dbac5ce
Compare
dranikpg
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when the last argument is a number because SNPrintF makes sure to write \0 even though we did not account of that when passing capacity. Since we allocate more than we use, the only thing we need to do is to pass larger capacity.
Signed-off-by: Roman Gershman [email protected]