fix(server): Fix replication on a single thread #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
commented
Jan 13, 2023
src/server/dflycmd.cc
Outdated
| @@ -428,7 +428,7 @@ uint32_t DflyCmd::CreateSyncSession(ConnectionContext* cntx) { | |||
| unique_lock lk(mu_); | |||
| unsigned sync_id = next_sync_id_++; | |||
|
|
|||
| unsigned flow_count = shard_set->size() + 1; | |||
| unsigned flow_count = shard_set->size() == 1 ? 1 : shard_set->size() + 1; | |||
There was a problem hiding this comment.
Not sure what comment to add:
"Only on a single thread the io fiber does not occupy a separare thread"?
There was a problem hiding this comment.
I would implement it differently. Just use "pool->size()". You can access thread pool via shardset imho
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
fix-single-thread
branch
from
b72c696 to
8fd7bf0
Compare
romange
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously replication didn't work with a single threaded master