fix(server): fix the bug where DF went over maxmemory limit #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
TuneEvictionPolicy
branch
from
88e27ef to
232a661
Compare
|
It seems like this is conflicting with your tiered storage |
…ntly Reproducible scenario: `zipfantest -c 20000000 -d 2000 -a 0.95 -p 10 -upper_bound 2000000` when dragonfly runs with: `--maxmemory=1G --cache_mode --proactor_threads=2` 1. Inside CanGrow() check we did not account for the additional segment when doing the test against the memory budget. 2. Our soft budget limit was too low, preventing more detailed checks to stop the allocation. Signed-off-by: Roman Gershman <[email protected]>
romange
force-pushed
the
TuneEvictionPolicy
branch
from
232a661 to
671677f
Compare
|
Not conflicting. It exposed the flakiness. I rebased now |
dranikpg
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducible scenario:
zipfantest -c 20000000 -d 2000 -a 0.95 -p 10 -upper_bound 2000000,when dragonfly runs with:
--maxmemory=1G --cache_mode --proactor_threads=2Problem:
Signed-off-by: Roman Gershman [email protected]