-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(actions): add support for debian packaging #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good if it worked for you :)
11a09c2
to
b109d4c
Compare
tools/packaging/debian/changelog
Outdated
@@ -0,0 +1,29 @@ | |||
dragonfly (0.1.1) unstable; urgency=low |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible, I prefer to avoid this text. Can we just write dragonfly (0.1.1); urgency=low
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if the answer is yes, then I would prefer that this line would be generated during the build
with the appropriate version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was auto generated, I will check, every time I made manual change there, it failed to parse the file, so just will make it work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but you removed CHANGELOG_SCRIPT directive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue with this, that I need to fix, regardless, right now, it would generate an installation file with version 1.1 always because it no longer have the version from the tags (the script that build this was what enable the correct version). Now this become constant, I need to see how to get back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then, please tell me if we can remove its contents drastically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I change the script back to use changelog that is generated as part of the build so that we would have a new version each time we are building a package. Otherwise it would always list the package as the same.
looks good overall |
Signed-off-by: Boaz Sade <[email protected]>
b109d4c
to
ec0ac23
Compare
Signed-off-by: Boaz Sade [email protected]
This complement PR 689.
And should complete issue #249
It would generate along with the normal binaries, an installation package for Debian, that can be used for installation on Debian based distributions.
There is a change in the package generation as well:
In order to ensure that we can generate the change log file, we are trying to fetch them if they do not exists.
The reason that this is required is to make sure that we are creating unique deb package with different version number for each of these builds.