Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actions): add support for debian packaging #696

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

boazsade
Copy link
Contributor

@boazsade boazsade commented Jan 16, 2023

Signed-off-by: Boaz Sade [email protected]

This complement PR 689.
And should complete issue #249
It would generate along with the normal binaries, an installation package for Debian, that can be used for installation on Debian based distributions.
There is a change in the package generation as well:
In order to ensure that we can generate the change log file, we are trying to fetch them if they do not exists.
The reason that this is required is to make sure that we are creating unique deb package with different version number for each of these builds.

Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good if it worked for you :)

@boazsade boazsade force-pushed the ci-with-deb-build branch 2 times, most recently from 11a09c2 to b109d4c Compare January 17, 2023 15:06
@boazsade boazsade marked this pull request as ready for review January 17, 2023 15:22
@boazsade boazsade requested a review from romange January 17, 2023 15:22
@@ -0,0 +1,29 @@
dragonfly (0.1.1) unstable; urgency=low
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, I prefer to avoid this text. Can we just write dragonfly (0.1.1); urgency=low ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if the answer is yes, then I would prefer that this line would be generated during the build
with the appropriate version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was auto generated, I will check, every time I made manual change there, it failed to parse the file, so just will make it work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but you removed CHANGELOG_SCRIPT directive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with this, that I need to fix, regardless, right now, it would generate an installation file with version 1.1 always because it no longer have the version from the tags (the script that build this was what enable the correct version). Now this become constant, I need to see how to get back

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then, please tell me if we can remove its contents drastically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change the script back to use changelog that is generated as part of the build so that we would have a new version each time we are building a package. Otherwise it would always list the package as the same.

@romange
Copy link
Collaborator

romange commented Jan 17, 2023

looks good overall

@boazsade boazsade marked this pull request as draft January 17, 2023 16:12
@boazsade boazsade marked this pull request as ready for review January 17, 2023 18:08
@boazsade boazsade requested a review from romange January 17, 2023 18:09
@boazsade boazsade merged commit be74fa0 into dragonflydb:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants