fix(server): fix getex command with persist can get time overflow #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boazsade
force-pushed
the
getex-with-persist-invalid-time-calc
branch
from
7480d34 to
99b84ef
Compare
|
Interestingly, I found the same issue today and fixed it, but not as well structured as with your solution 🙂 |
dranikpg
previously approved these changes
Jan 19, 2023
romange
reviewed
Jan 19, 2023
romange
reviewed
Jan 19, 2023
|
Boaz, Since Vlad already merged his code, please remove Vlad's check :)
You could pass a dcheck there that persist is false instead.
…On Thu, Jan 19, 2023 at 1:32 PM Vladislav ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#707 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCEU547LNYV5PBDE62LWTEQ5RANCNFSM6AAAAAAUADTVDA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
boazsade
force-pushed
the
getex-with-persist-invalid-time-calc
branch
from
99b84ef to
671b451
Compare
romange
reviewed
Jan 19, 2023
Signed-off-by: Boaz Sade <[email protected]>
boazsade
force-pushed
the
getex-with-persist-invalid-time-calc
branch
from
671b451 to
5284ec2
Compare
romange
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boaz Sade [email protected]
This fix issue #705
GETEX command with PERSIST will result in integer overflow since in this case, the expiration time cannot be calculated.
The fix is, in case we have persist enable, don't try to calculate the persist time, just set as persist value.